When reviewing a PR I try to elaborate on my proposals for two reasons:
1. Out of respect to my colleague
Every piece of code is part of an effort that took time and thought. Requesting a code change by simply asking it (
i don't like it, change it) or by dictating it (
do it this way) demotes all the work that has been done.
I figured that, since my colleague spent a few hours to come up with a solution I owe her/him more than a few seconds!
2. I solidify my knowledge or even better, learn something new
By trying to justify the reason behind a request I end up understanding better why I prefer a solution or a format over another.
When I provide an example or when I do a mini investigation to help me clarify why something must change I often find that (a) many things that I thought I knew were not as I had them in mind and (b) I now understand a concept much better because I had to write about it. You don’t master something if you can’t explain it!
PS: never forget that it might say “request a change” but in reality you start a conversation between two professionals that will eventually benefit of the project